Update dotenv.rst #11200
Merged
Update dotenv.rst #11200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it seems standard practice is to no longer use `getenv()` due to it not being thread safe. symfony/symfony@21a909a Updated the docs to remove reference to that function. Would we want to go so far as to add a note to **not** use `getenv()`?
|
Thank you Andrew! Let's just not mention it, if we get many PRs that add getenv() to this list or questions about it, we can always add a short warning. |
wouterj
added
the
⭐️ EU-FOSSA Hackathon
wouterj
added a commit
that referenced
this pull request
Apr 6, 2019
This PR was submitted for the 4.2 branch but it was merged into the 3.4 branch instead (closes #11200). Discussion ---------- Update dotenv.rst it seems standard practice is to no longer use `getenv()` due to it not being thread safe. symfony/symfony@21a909a Updated the docs to remove reference to that function. Would we want to go so far as to add a note to **not** use `getenv()`? Commits ------- 5be35bf Update dotenv.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems standard practice is to no longer use
getenv()due to it not being thread safe.symfony/symfony@21a909a
Updated the docs to remove reference to that function. Would we want to go so far as to add a note to not use
getenv()?